Skip to content

fix: certs and file #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 2, 2025
Merged

fix: certs and file #882

merged 5 commits into from
Jun 2, 2025

Conversation

@vaishakdinesh
Copy link
Member

@vaishakdinesh vaishakdinesh commented May 29, 2025 •
edited
Loading

resources:

  • cloudflare_keyless_certificate: Took a page out the v4 implementation since the certificate will not be returned
  • cloudflare_stream_watermark: Similar concept to the certificate but for a file.
  • cloudflare_authenticated_origin_pulls_certificate: Similar but for private key

@vaishakdinesh vaishakdinesh marked this pull request as draft May 29, 2025 20:37
@vaishakdinesh vaishakdinesh changed the title Vaishak/keyless stream fix: certs and file May 29, 2025
@vaishakdinesh vaishakdinesh marked this pull request as ready for review May 29, 2025 20:39
@vaishakdinesh vaishakdinesh removed the request for review from jacobbednarz May 29, 2025 23:29
musa-cf
musa-cf approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@musa-cf musa-cf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vaishakdinesh vaishakdinesh merged commit 0893b36 into master Jun 2, 2025
8 checks passed
@vaishakdinesh vaishakdinesh deleted the vaishak/keyless-stream branch June 2, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@musa-cf musa-cf musa-cf approved these changes

@mgirouard mgirouard Awaiting requested review from mgirouard

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vaishakdinesh @musa-cf