First pass for adding v5 provider support #802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| placeholderReplacer := strings.NewReplacer("{account_id}", accountID, "{zone_id}", zoneID) | ||
| endpoint = placeholderReplacer.Replace(endpoint) | ||
|
|
||
| client := cloudflare.NewClient() |
There was a problem hiding this comment.
do we need to rename it here? we can also just alias cloudflare-go to something else instead of reassigning here.
There was a problem hiding this comment.
I've opted to remove the reassignment so that the new Go client is api and old one is apiv0, I can change that if you'd like though
jacobbednarz
approved these changes
Feb 26, 2025
|
lgtm too! |
vaishakdinesh
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is best reviewed commit-by-commit.
Changes include: