chore(release): add postinstall script to warn users of name change - #293
Merged
Merged
Conversation
Since we have recently changed the name of this module to 'cloudevents', users may not be aware that version 2.0.2 is out of date, since it won't automatically be upgraded on `npm install`. This commit adds a postinstall script to warn users of this fact, and adds a bold, top-level warning to the README. Fixes: cloudevents#291 Signed-off-by: Lance Ball <lball@redhat.com> squash
lance
added
type/enhancement
lance
requested review from
danbev,
fabiojose,
helio-frota and
lholmquist
and removed request for
a team
July 30, 2020 19:01
lholmquist
approved these changes
Jul 30, 2020
lholmquist
left a comment
lholmquist
left a comment
Contributor
There was a problem hiding this comment.
LGTM
somewhat related, the CI stuff didn't run for this PR,
Member
Author
That's because in the 2.x line, we are only running CI on pushes and PRs to |
Member
Author
|
Also related, it's impossible to test this behavior without simply running |
helio-frota
approved these changes
Jul 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Since we have recently changed the name of this module to 'cloudevents', users
may not be aware that version 2.0.2 is out of date, since it won't automatically
be upgraded on
npm install.Description
This commit adds a postinstall script to warn users of this fact, and adds a
bold, top-level warning to the README.
Signed-off-by: Lance Ball lball@redhat.com