organize the supported features section#411
Open
sparty02 wants to merge 1 commit intocloudevents:mainfrom
Open
organize the supported features section#411sparty02 wants to merge 1 commit intocloudevents:mainfrom
sparty02 wants to merge 1 commit intocloudevents:mainfrom
Conversation
Organizing for readability and a better "at a glance" understanding of the state of what this SDK supports. As a follow-up, I'd like to propose re-organizing the maven modules under "protocols" and "formats" modules, but I can address that in a different PR if you agree with that change, which would look something like this: ``` ├── api ├── benchmarks ├── bom ├── core ├── docs ├── examples │ ├── amqp-proton │ ├── basic-http │ ├── kafka │ ├── restful-ws-quarkus │ ├── restful-ws-spring-boot │ ├── spring-function │ ├── spring-reactive │ ├── spring-rsocket │ └── vertx ├── formats │ ├── avro │ ├── json-jackson │ └── protobuf ├── protocols | ├── amqp | ├── http | │ ├── basic | │ ├── restful-ws | │ ├── restful-ws-integration-tests | │ └── vertx | ├── kafka ├── spring └── sql ```
pierDipi
requested changes
Nov 9, 2021
Member
pierDipi
left a comment
pierDipi
left a comment
There was a problem hiding this comment.
Can you fix the DCO check https://github.com/cloudevents/sdk-java/pull/411/checks?check_run_id=3302598535?
Comment on lines
+40
to
+41
| | AMQP | :x: | :x: | | ||
| | - _[Proton](amqp)_ | :heavy_check_mark: | :heavy_check_mark: | |
Member
There was a problem hiding this comment.
Can you replace the x with heavy_check_mark here since there is a binding implementation?
Suggested change
| | AMQP | :x: | :x: | | |
| | - _[Proton](amqp)_ | :heavy_check_mark: | :heavy_check_mark: | | |
| | AMQP | :heavy_check_mark: | :heavy_check_mark: | | |
| | - _[Proton](amqp)_ | :heavy_check_mark: | :heavy_check_mark: | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Organizing for readability and a better "at a glance" understanding of the state of what this SDK supports. As a follow-up, I'd like to propose re-organizing the maven modules under "protocols" and "formats" modules, but I can address that in a different PR if you agree with that change, which would look something like this: