Skip to content

Conversation

@mkorszun
Copy link

No description provided.

@schu
Copy link

schu commented Oct 29, 2014

configs/SquareAndroid.xml missing newline at EOF.

Tab and indent = 4 is consent among the Java users @ cloudcontrol (i.e. do you think it's OK to merge without further discussion)?

@mkorszun
Copy link
Author

@schu lets then use this pull request to finally decide. I am personally strict about spaces instead of tabs - this formatters use spaces.

@schu
Copy link

schu commented Oct 29, 2014

Perfect. I go with whatever you decide, as long as it's consistent and easy-to-setup for reluctant Java users like me. We should mention this in the core README when it's merged.

@TooAngel
Copy link

I personally prefer TAB over spaces (exception python because PEP8 defined spaces), because this enables you to define in your IDE how you want to have it presented.

But I think this is should be a dev team decission - no hard feelings as long as my formatter takes care

@mkorszun
Copy link
Author

Just to make it clear - this is so far only Intellij formatter.

@vervas
Copy link

vervas commented Oct 29, 2014

I'm for 4 spaces but I would wait for Alex's and Stefan's opinion since they use it too.

@sfriesel
Copy link

I'm for tabs, just like Dimitris https://github.com/cloudControl/core/commit/c7488ffedf6d06876b3cd96eb0d39b0c53f9346f ;)

some numbers jfyi:
70% LOC of the core are tab indented
47 files indent exclusively with space
129 files indent exclusively with tab
39 files have mixed indents

@mkorszun
Copy link
Author

@alpe @fern4lvarez any preferences?

@fern4lvarez
Copy link

For Python or Ruby choice is easy, always spaces. For Java I tend to see tabs more convenient (same with Go, where there's no discussion at all thanks to gofmt), as more of our codebase is already using tabs. My opinion on this is not that strong and this document, which seems respectable, points to the spaces option though.

@mkorszun
Copy link
Author

mkorszun commented Nov 3, 2014

Ok, lets then go with tabs. Will update formatters.

@mkorszun mkorszun changed the title Tab & indent = 4 Use tabs with default size 4 Nov 3, 2014
vervas added a commit that referenced this pull request Nov 3, 2014
@vervas vervas merged commit 7698f2a into master Nov 3, 2014
@vervas vervas deleted the adjust-tabs branch November 3, 2014 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants