Skip to content

api_client: Add license info to api_client crate#7657

Merged
rbradford merged 1 commit intocloud-hypervisor:mainfrom
stevenhorsman:api-client-license
Feb 3, 2026
Merged

api_client: Add license info to api_client crate#7657
rbradford merged 1 commit intocloud-hypervisor:mainfrom
stevenhorsman:api-client-license

Conversation

@stevenhorsman
Copy link
Contributor

@stevenhorsman stevenhorsman commented Feb 3, 2026

Hi team, in kata-containers we use the api_client crate, but it's currently failing our cargo deny check due to missing license, and there aren't any license files within the crate, so I haven't found a good way to work around this.

Alternatively I'd be happy to add the license to the workspace crate and then reference it here, but that seems to clash with the direction of the project in #7525.

For reference, here is the cargo deny output:


warning[no-license-field]: license expression was not specified in manifest for crate 'api_client = 0.1.0'
 ├ api_client v0.1.0
   └── ch-config v0.1.0
       └── hypervisor v0.1.0
           ├── (dev) hypervisor v0.1.0 (*)
           ├── resource v0.1.0
           │   ├── common v0.1.0
           │   │   ├── linux_container v0.1.0
           │   │   │   └── runtimes v0.1.0
           │   │   │       ├── runtime-rs v0.1.0
           │   │   │       ├── service v0.1.0
           │   │   │       │   └── shim v0.1.0
           │   │   │       │       └── runtime-rs v0.1.0 (*)
           │   │   │       ├── shim v0.1.0 (*)
           │   │   │       └── shim-ctl v0.1.0
           │   │   ├── runtime-rs v0.1.0 (*)
           │   │   ├── runtimes v0.1.0 (*)
           │   │   ├── service v0.1.0 (*)
           │   │   ├── shim-ctl v0.1.0 (*)
           │   │   ├── virt_container v0.1.0
           │   │   │   └── runtimes v0.1.0 (*)
           │   │   └── wasm_container v0.1.0
           │   │       └── runtimes v0.1.0 (*)
           │   ├── linux_container v0.1.0 (*)
           │   ├── runtimes v0.1.0 (*)
           │   ├── virt_container v0.1.0 (*)
           │   └── wasm_container v0.1.0 (*)
           ├── runtimes v0.1.0 (*)
           └── virt_container v0.1.0 (*)

warning[unlicensed]: a valid license expression could not be retrieved for the crate
  ┌─ git+https://github.com/cloud-hypervisor/cloud-hypervisor?tag=v27.0#api_client@0.1.0-synthesized.toml:2:9
  │
2 │ name = "api_client"
  │         ━━━━━━━━━━
  │
  ├ api_client v0.1.0 (*)

error[unlicensed]: api_client = 0.1.0 is unlicensed
 ├ api_client v0.1.0 (*)

@stevenhorsman stevenhorsman requested a review from a team as a code owner February 3, 2026 09:53
rbradford
rbradford reviewed Feb 3, 2026
View reviewed changes
@stevenhorsman
api_client: Add license info to api_client crate
54f2c32 
In kata-containers we use the api_client crate, but it's currently
failing our cargo deny check due to missing license, and there aren't
any license files within the crate, so I haven't found a good way to
work around this.

Alternatively I'd be happy to add the license to the workspace crate
and then reference it here, but that seems to clash with the direction
of the project in cloud-hypervisor#7525.

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
@rbradford rbradford enabled auto-merge February 3, 2026 14:36
@rbradford rbradford added this pull request to the merge queue Feb 3, 2026
Merged via the queue into cloud-hypervisor:main with commit 512c3ea Feb 3, 2026
43 of 45 checks passed
@stevenhorsman stevenhorsman deleted the api-client-license branch February 3, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rbradford rbradford rbradford approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stevenhorsman @rbradford