virtio-devices: pci_common_config: Remove warning for feature pages > 2#7423
Merged
rbradford merged 1 commit intocloud-hypervisor:mainfrom Oct 22, 2025
Conversation
phip1611
approved these changes
Oct 20, 2025
likebreath
approved these changes
Oct 20, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
RuoqingHe
approved these changes
Oct 20, 2025
Member
RuoqingHe
left a comment
RuoqingHe
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @rbradford ❤️
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
The virtio spec defines the feature bit range and 4 x 32-bit pages. However no features are currently defined with bits > 63. However Linux has now started acking features in those higher pages. Since this is harmless (we drop the acks to those feature pages) and quietly return 0 for available features in those higher pages this warning can be removed. Fixes: cloud-hypervisor#7414 Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
rbradford
force-pushed
the
2025-10-20-handle-high-virtio-feature-bits
branch
from
2589127 to
609df31
Compare
Merged
via the queue into
cloud-hypervisor:main
with commit Oct 22, 2025
7d6c450
42 of 43 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The virtio spec defines the feature bit range and 4 x 32-bit pages.
However no features are currently defined with bits > 63. However Linux
has now started acking features in those higher pages. Since this is
harmless (we drop the acks to those feature pages) and quietly return 0
for available features in those higher pages this warning can be
removed.
Fixes: #7414
Signed-off-by: Rob Bradford rbradford@rivosinc.com