vmm: fix hotplugging when max_cpus > 255#7349
Merged
rbradford merged 1 commit intocloud-hypervisor:mainfrom Sep 12, 2025
Merged
vmm: fix hotplugging when max_cpus > 255#7349rbradford merged 1 commit intocloud-hypervisor:mainfrom
rbradford merged 1 commit intocloud-hypervisor:mainfrom
Conversation
Signed-off-by: Peter Oskolkov <posk@posk.io>
likebreath
approved these changes
Sep 12, 2025
Member
likebreath
left a comment
likebreath
left a comment
There was a problem hiding this comment.
Code changes look good to me. The ACPI table did define the CSEL as 32 bits:
cloud-hypervisor/vmm/src/cpu.rs
Line 2265 in ad3f946
rbradford
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration test_cpu_hotplug passes; a couple of manual hotplug tests with max_cpus = 300 seem ok (I have never played with CPU hotplug before).