build: Bump thiserror version#6896
Merged
rbradford merged 2 commits intocloud-hypervisor:mainfrom Jan 6, 2025
Merged
Conversation
Member
rbradford
commented
Jan 2, 2025
rbradford
commented
- block: qcow: Use constant in error message
- build: Bump thiserror version
likebreath
approved these changes
Jan 2, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This avoids ambiguity of parameters:
error: ambiguous reference to positional arguments by number in a tuple variant; change this to a named argument
--> block/src/qcow/mod.rs:48:48
|
48 | #[error("File larger than max of {}: {0}", MAX_QCOW_FILE_SIZE)]
| ^^^^^^^^^^^^^^^^^^
Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
rbradford
force-pushed
the
2025-01-02-bump-thiserror
branch
from
723d49a to
b973931
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
cloud-hypervisor:main
with commit Jan 6, 2025
eeae63b
39 of 40 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.