Basic proof of concept for custom commands#2102
Open
frankitox wants to merge 2 commits intoclojure-lsp:masterfrom
Open
Basic proof of concept for custom commands#2102frankitox wants to merge 2 commits intoclojure-lsp:masterfrom
frankitox wants to merge 2 commits intoclojure-lsp:masterfrom
Conversation
Contributor
|
i know this is a WIP but thought I'd mention that the clj-kondo hook api would be worthwhile to copy. node creation fns as well as node type predicates: |
Author
|
Right, I'll add that info to the issue. I rather wait until everything is a little clearer to modify the code |
frankitox
force-pushed
the
master
branch
3 times, most recently
from
acf998c to
b041a23
Compare
Member
|
@frankitox I intend to take a look soon at this, is there anything missing from your part? |
Author
|
Hi! Not really. There's two commits. First has the implementation, the second one can be discarded and contains custom commands I've been toying with. |
Author
|
@ericdallo let me know if you start working on this! I'd like to keep an eye on what namespaces make it to the API |
Member
|
@frankitox sorry, I'm focusing on Conj's talk this weekend, I intend to check that after get back from Conj! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There's only two commits for now. First one has the implementation. Second one a basic custom command to illustrate the use.
TODO
clojure-lsp.exports/linters. Use/commandsfor custom commands?TODO further
docsfolder)