Repository navigation
Async IDC: Preserve V10 names and type IDC outbox signature hashes - #6364
Open
Shubham8287 wants to merge 2 commits into
Open
Shubham8287 wants to merge 2 commits into
Shubham8287 wants to merge 2 commits into
Conversation
Shubham8287
changed the title
Shubham8287
changed the title
Shubham8287
force-pushed
the
shub/idc-case-conversion-roundtrip
branch
from
October 25, 2026 11:47
46a0313 to
b320a20
Compare
Shubham8287
force-pushed
the
shub/idc-case-conversion-roundtrip
branch
from
October 25, 2026 11:49
b320a20 to
722eaa7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Taken out from #6001.
Fix
ModuleDef→RawModuleDefV10round trip bug.:spacetime generatedoes the round trip fromModuleDef -> RawModuleDef -> ModuleDeffor it's implementation, conversion toRawModuleDefV10does not put anyCaseConversionPolicycausing it to defaulting tosnake_case, which appliedsnake_casecasing on reRawModuleDefV10toModuleDefconversion, resulting in different output. Fixes that by harding case conversion policy to None.Use typed
Hashvalues for IDC outbox signatures. Changes the outbox signature type to Hash as that's more appropriate than String, we can not fix it on system table, hence do the conversion at boundaryAPI and ABI breaking changes
NA
Rollback safety impact
n/a
Expected complexity level and risk
2
Testing
NA