Repository navigation
fix(bindings-typescript): support cross-bundle Range instances in index scans (#6299) - #6350
Open
Tyagiquamar wants to merge 1 commit into
Open
Tyagiquamar wants to merge 1 commit into
Tyagiquamar wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6299.
When using
spacetimedb/server/test-utilsor module code bundled across entrypoints, filtering or deleting through a table index using aRangeinstance failed becauserange instanceof Rangeevaluated tofalse.dist/server/test-utils/index.mjsanddist/server/index.mjsare separate bundles, each inlining its own copy ofRange. Consequently:range instanceof Rangeevaluates tofalseacross bundles.Rangeobject as a single point.Timestamp), the point serializer throwsTypeError: Cannot convert undefined to a BigInt.Solution
Symbol.for('spacetimedb.Range')brand toRange.prototypeand addedRange.isRange(val)/ exportedisRange(val)predicate.crates/bindings-typescript/src/server/runtime.ts, replacedinstanceof Rangechecks in single-column index filter/delete and multi-column index scan paths withisRange(...).crates/bindings-typescript/tests/index_prefix_filter.test.tsverifying that cross-bundle Range instances work seamlessly for both single-column and multi-column btree index filters and deletes.Verification
vitest run tests/index_prefix_filter.test.ts: all 11 tests passed.tsc -p tsconfig.build.json: type check passed.prettier --checkon modified files: passed.