-
Notifications
You must be signed in to change notification settings - Fork 160
Support for edn tagged reader literal notation as noted in issue 113. #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test/clj_time/coerce_test.clj
Outdated
| (to-edn o))) | ||
| (date-time 1998 4 25) | ||
| (date-midnight 1998 4 25) | ||
| (date-midnight 1998 4 25) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this second date-midnight line be some other call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a paste error. The tests are intended to be the same cases as in test-to-string. Thank you for the catch.
|
Nice! I left a question on one line of the commit. Also, could you update the README as part of this PR with some examples? (the readme examples are run as tests with Midje so they serve two purposes: documentation and additional tests). Thanks. |
|
Many thanks! 👍 |
|
BTW, the test instructions were correct as far as I can tell. If you Can you confirm you get that behavior without running |
|
Yes, that is what I am getting. I also cleaned up the readme to be slightly more concise, and more consistent with the rest of the text. |
|
Since I already merged the PR, feel free to send any further updates in a separate PR. I'm updating the change log and plan to cut 0.14.6 later today with these additions. |
|
I removed the explicit call to test-readme in the instructions. If I run it I get: But a plain |
|
Ok, I will follow up with another. Sorry for the extra work. I need github to do a convincing preview of the markdown for me. Much appreciated! |
Added tagged literal support as described in #113.