Extend Inst to org.joda.time.ReadableInstant on Clojure 1.9 #249
Conversation
|
The change to |
|
@seancorfield beat me to it :) Otherwise the idea is sound 👍. |
|
Excellent, thank you, have updated the pull request. |
|
It's a minor nit-pick but the test(s) will "only" get exercised in the |
|
@seancorfield Yes, and that is why I had renamed the profile to Thank you both for the prompt review and merge! |
|
@michaelklishin I updated the changelog -- do you think this warrants a 0.14.4 release? |
|
@seancorfield it's a pretty useful thing, so why not ship it sooner. |
|
|
|
Perfect, thank you! |
3 participants
The change proposed here extends the
Instprotocol toorg.joda.time.ReadableInstantwhenclj-time.coreis loaded. SinceInstwas only added in Clojure 1.9, the extension is conditional on availability ofInst.This should resolve #248.
Notes about the changes:
org.joda.time.ReadableInstant(which is implemented byorg.joda.time.DateTime) seems best suited for extension toInst.:specto:1.9to better reflect what’s in the tests (not just spec).This changeset seems reasonable to me but of course I am happy to incorporate any feedback you might have.