totally inelegant approach to hopefully stopping flakey tests#852
Merged
vilmibm merged 1 commit intocli:masterfrom Apr 29, 2020
vilmibm:spinnertest
Merged
totally inelegant approach to hopefully stopping flakey tests#852vilmibm merged 1 commit intocli:masterfrom vilmibm:spinnertest
vilmibm merged 1 commit intocli:masterfrom
vilmibm:spinnertest
Conversation
Closed
probablycorey
approved these changes
Apr 29, 2020
Contributor
probablycorey
left a comment
probablycorey
left a comment
There was a problem hiding this comment.
This works for me. Should we admit defeat against the race condition and keep using this, or do you see this as a temporary fix?
Contributor
Author
|
I don't see a need for us to test this spinner in an automated fashion and i see this as a fairly long term solution, yup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is not graceful but it will theoretically un-flake our tests