Skip to content

Support www.github.com git remote URLs#709

Merged
mislav merged 3 commits intomasterfrom
www-hostname-support
Mar 30, 2020
Merged

Support www.github.com git remote URLs#709
mislav merged 3 commits intomasterfrom
www-hostname-support

Conversation

@mislav
Copy link
Copy Markdown
Contributor

@mislav mislav commented Mar 27, 2020

Using www.github.com in git remote URLs is certainly not common, but GitHub technically supports it and it's not hard for us to support it too.

Fixes #693

Bonus:

  • transition repoFromURL to table-driven test
  • add code docs for ghrepo package

@mislav mislav merged commit 988d36d into master Mar 30, 2020
@mislav mislav deleted the www-hostname-support branch March 30, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

www.github.com not recognized as a GitHub hostname

2 participants