Skip to content

Prevent crash when encountering "STALE" check conclusion#707

Merged
mislav merged 1 commit intomasterfrom
stale-check-conclusion
Mar 30, 2020
Merged

Prevent crash when encountering "STALE" check conclusion#707
mislav merged 1 commit intomasterfrom
stale-check-conclusion

Conversation

@mislav
Copy link
Copy Markdown
Contributor

@mislav mislav commented Mar 27, 2020

The "STALE" conclusion had shipped this January and is basically a conclusion that can only be reported by GitHub and not explicitly set by any integrations.

I could not decide whether to map it to a "success" or a "failure" state, so I chose "pending" instead.

Fixes #705

The "STALE" conclusion has shipped this January and is basically a
conclusion that can only be reported by GitHub and not explicitly set by
any integrations.
@mislav mislav merged commit d4692c3 into master Mar 30, 2020
@mislav mislav deleted the stale-check-conclusion branch March 30, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gh pr status -> panic: unsupported status: "STALE"

2 participants