Avoid auto-forking/pushing an already pushed branch in pr create#704
Merged
Avoid auto-forking/pushing an already pushed branch in pr create#704
pr create#704Conversation
This is so we can pass a list of full qualified refs and have them resolved for both existence and their commit hashes.
A valid remote specificication read from `branch.<name>.remote` git config can be a URL, a `.`, a filesystem path, and a remote name. When detecting the remote name, be sure not to take filesystem paths instead.
A branch is considered already pushed if its HEAD commit hash matches the commit hash of one of the remote tracking branches: `refs/remotes/<remote>/<branch>` This mechanism allows the user to: - Choose a remote as push target for their branch different than the one that would automatically get chosen for them by `pr create`; - Avoid a `git push` operation (and its associated git hooks) if a push was not necessary in the first place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A branch is considered already pushed if its HEAD commit hash matches the commit hash of one of the remote tracking branches:
refs/remotes/<remote>/<branch>This mechanism allows the user to:
pr create;git pushoperation (and its associated git hooks) if a push was not necessary in the first place.Drawbacks:
git switch -c my-feature origin/master. With git default settings, this will auto-setup merge configuration (seebranch.autoSetupMergein git config), which gh could potentially falsely interpret as a push configuration as well, be it not for the strict commit hash matching.Fixes #681
Ref. #684 #350 #684
TODO: