Conversation
mislav
approved these changes
Mar 24, 2020
Contributor
mislav
left a comment
mislav
left a comment
There was a problem hiding this comment.
Nice and elegant. Thank you!
Comment on lines
+397
to
+399
| if pr.HeadLabel() == headBranch { | ||
| if baseBranch != "" { | ||
| if pr.BaseRefName != baseBranch { |
Contributor
There was a problem hiding this comment.
Nit: couldn't have all this be collapsed into a single conditional?
Contributor
Author
There was a problem hiding this comment.
they could; i often over-nest because i find it easier to read and reason about
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #686
when checking for existing pull requests for a given branch we weren't taking the base branch into
account, thus preventing -B from being useful once a pull request existed for a given branch.