Creating a PR now always prioritizes an existing fork as a push target#680
Merged
Creating a PR now always prioritizes an existing fork as a push target#680
Conversation
Before: the default push target for the current branch in `pr create` was the first repository found among git remotes that has write access. Now: the default push target is the fork the base repo, if said fork exists and has write access, falling back to old behavior otherwise. This change in the default is to facilitate contributions to projects that have a hard requirement that all pull requests (even those opened by people with write access to that project) come from forks.
vilmibm
approved these changes
Mar 19, 2020
Contributor
vilmibm
left a comment
vilmibm
left a comment
There was a problem hiding this comment.
just some questions but nothing blocking. nice work!
command/pr_create.go
Outdated
| // TODO: figure out what to name the new git remote | ||
| gitRemote, err := git.AddRemote("fork", baseRepoURL, headRepoURL) | ||
| // TODO: prevent clashes with another remote of a same name | ||
| gitRemote, err := git.AddRemote("fork", headRepoURL, "") |
Contributor
There was a problem hiding this comment.
as of this pull request, the third argument of AddRemote is unused anywhere. Do we still need to support it?
Contributor
Author
There was a problem hiding this comment.
Good call! I've simplified the AddRemote implementation
The 2nd argument now unused since we've determined that, in practice, we can safely fetch git objects from a freshly created fork on GitHub and that we don't need the remote URL-swapping workaround.
safv12
approved these changes
Mar 24, 2020
This API was just fixed in github.com, but it will take a while for the change to propagate to GitHub Enterprise installs, so guard ourselves from false positives when querying forks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: the default push target for the current branch in
pr createwas the first repository found among git remotes that I have write access to, even if it is the same as the base repository.Now: the default push target is the fork of the base repo, if said fork exists and I have write access to it (even if it's not listed among git remotes), falling back to old behavior otherwise.
This change in the default is to facilitate contributions to projects that have a hard requirement that all pull requests (even those opened by people with write access to the project) always come from forks. If a fork exists, it will automatically get used as a push target.
Fixes #350