Skip to content

Check for existing pull request on pr create#668

Merged
vilmibm merged 5 commits intomasterfrom
mislav/check-if-pr-exists
Mar 18, 2020
Merged

Check for existing pull request on pr create#668
vilmibm merged 5 commits intomasterfrom
mislav/check-if-pr-exists

Conversation

@mislav
Copy link
Copy Markdown
Contributor

@mislav mislav commented Mar 18, 2020

Extends #648 with my fixes

Fixes #649

Tarasovych and others added 5 commits March 13, 2020 14:02
- Only check for existing PRs if `--web` wasn't given
- Fix detecting PRs from forks
- Improve order of error handling: local validation errors are handled
  earlier than the ones that have to consult the API
@mislav mislav requested a review from vilmibm March 18, 2020 12:15
@vilmibm vilmibm merged commit 3334bdd into master Mar 18, 2020
@mislav mislav deleted the mislav/check-if-pr-exists branch March 27, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pr create shoud fail faster if a PR already exists

3 participants