Conversation
mislav
left a comment
mislav
left a comment
There was a problem hiding this comment.
This looks good, thank you! One note though
There was a problem hiding this comment.
Thanks for the contribution @eddumelendez! Sorry for dropping in after @mislav had already approved it, but I'm wondering if this is intended to fix #389? I'd like to ensure we don't confuse people by supporting filtering by author for issues, but not for pull requests, so I'd love that to be part of this as well if you're able to add that.
If you don't mind adding more context to the PR body so people don't have to look at the code to figure out how this works (how it's invoked with -A or --author is a good example), that would also be really helpful!
|
@billygriffin thanks for pointing me to the issue! I was working on this for PRs too in another branch but I couldn't find |
|
@eddumelendez Apologies, it looks like you're right that filtering by author is not yet available from the GraphQL API. I'm going to dismiss my review so this can get merged, and update the associated issue to only be about pull requests, and we'll identify that as blocked on the API side. And hopefully we'll be able to get that filtering added soon to make this available for PRs as well. Thanks again for the contribution! |
3 participants
This provides support for filtering issues by author with the
issue listcommand.The flags are
-Aand--author. Fixes #389.Edit: PR support for filtering by author isn't available from the API so that'll need to happen in a follow up PR. I (Billy) updated #389 to just be scoped to issues so this can close that issue when it's merged.