Conversation
vilmibm
reviewed
Nov 12, 2019
Contributor
vilmibm
left a comment
vilmibm
left a comment
There was a problem hiding this comment.
looks good to me! just curious about the use of panic
| case "PENDING": | ||
| summary.Pending++ | ||
| default: | ||
| panic(fmt.Errorf("unsupported status: %q", status.State)) |
Contributor
Author
There was a problem hiding this comment.
Good question! Previously, this method didn't have error conditions, but then I added the switch statement and I think I covered all possible states, but just in case I didn't, or some new states get added, we get a panic with a stack trace rather than a silent failure.
We could totally return an error here; I just made a call (also, pressured for time) that all states were covered and that I don't expect this panic to actually get triggered in day-to-day use.
Contributor
There was a problem hiding this comment.
ah, I get it! I think that's a fair use of a panic.
| case "FAILURE", "CANCELLED", "TIMED_OUT", "ACTION_REQUIRED": | ||
| summary.Failing++ | ||
| default: | ||
| panic(fmt.Errorf("unsupported check conclusion: %q", checkRun.Conclusion)) |
vilmibm
approved these changes
Nov 13, 2019
Stonre
pushed a commit
to Stonre/strands-fork
that referenced
this pull request
Jul 21, 2025
* Added hyphen to allowed characters in tool name validation
This comment was marked as spam.
This comment was marked as spam.
1 similar comment
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reapplies #45 to the
masterbranch with bonus tweaks.Ref. https://github.com/github/ce-cli/issues/18