fix: inconsistent format between issue list and status#532
fix: inconsistent format between issue list and status#532mislav merged 2 commits intocli:masterfrom
Conversation
mislav
left a comment
mislav
left a comment
There was a problem hiding this comment.
Nice work! Just few little suggestions, plus a request: since this tweaks the output of issue status, could you apply the same improvements to pr status?
Thanks! This looks great ✨
|
PR status has optional |
Hmm that's a good point. Right now it might be tricky to force those into table fields. Please disregard my last comment and hold off porting |
There was a problem hiding this comment.
This looks good if we just consider issue status output, but I would hold off merging until we figure out whether it's a problem that this makes the output different than pr status, and discuss how could we apply the same formatter there—PR status has more fields, so it might be more complicated to force it to a table layout.
|
Yap. I'm glad that this pr is approved :) I'll be waiting for final decisions. |
|
I think since the info and layout of pr status is more complex we shouldn’t force the table layout. So I think this is good to go! |
4 participants
Currently,
issue listandissue statushave different printing formats.This PR adds the
agesection forissue listand uses thetablewriterforissue statusto keep the format consistency between them.Current version
Fixed version