Conversation
probablycorey
approved these changes
Nov 7, 2019
| var issueCreateCmd = &cobra.Command{ | ||
| Use: "create", | ||
| Short: "Create a new issue", | ||
| RunE: issueCreate, |
Contributor
There was a problem hiding this comment.
Does it make sense to move these into the init function because they are only used in the init function?
Contributor
Author
There was a problem hiding this comment.
You mean vars like issueCreateCmd? They might be only used in init for now, but tests might need to access them too, so that's why I think it's best to keep them at package-level.
api/queries_issue.go
Outdated
| } | ||
|
|
||
| return result.Repository.Id, nil | ||
| } |
Contributor
There was a problem hiding this comment.
Pulling this into a separate file is a wonderful idea. Makes it easier to read and maintain 💯
mislav
pushed a commit
that referenced
this pull request
Sep 28, 2021
Liveshare client upgrade to v0.6.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports #44 to master
Ref. https://github.com/github/ce-cli/issues/18