Correctly handle Windows paths when creating gists #5173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliAutomation
added
the
external
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports #5113
When creating gists on Windows, the filename is not correctly parsed when the file path contains
\path separators, resulting in gists being created with the full file path as the name.This is due to using
path, which doesn't handle OS-specific file separators. Switching tofilepathresolves the issue - https://pkg.go.dev/path/filepathI've validated that the existing code fails the tests fail on a Windows machine when the file paths are created using OS-specific file separators (
filePath.Join).This is the recommended solution to #5113 (comment), but does not resolve the original request to allow defining a file name when creating gists.