fix(release): discussion category with assets#5019
Conversation
cliAutomation
added
the
external
vilmibm
previously requested changes
Jan 25, 2022
Contributor
vilmibm
left a comment
vilmibm
left a comment
There was a problem hiding this comment.
Thanks! This is a good start, but I'd like to see two things: 1) a typed struct passed to publishRelease instead of a map and 2) tests
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4993
when
--discussion-categoryand additional assets are given at the same time, the created release doesn't contain the specified discussion.$ gh release create abc/1.2.3-rc2 --discussion-category "Announcements" --generate-notes hello.txtthere are two reasons for causing this bug.
in the draft creation phase,
discussion_category_nameis attached to the body but it is invalid 'cause the second reason.in the publish phase,
--discussion-categoryis not included, so that the--discussion-categorysetting isn't applied to the created release.Changes
To fix that, I just add
discussion_category_namevalue in the publish release api's body.