Conversation
mislav
approved these changes
Nov 6, 2019
Contributor
mislav
left a comment
mislav
left a comment
There was a problem hiding this comment.
Good catch! I must have not tested "all" at all. I think I got "all" from the REST API and somehow projected it here.
| graphqlState = []string{"MERGED"} | ||
| case "all": | ||
| graphqlState = "ALL" | ||
| graphqlState = []string{"OPEN", "CLOSED", "MERGED"} |
Contributor
There was a problem hiding this comment.
Doesn't MERGED also imply CLOSED? I'm wondering if we have to explicitly list it here.
Contributor
Author
There was a problem hiding this comment.
no, merged is a distinct state. closed means the PR was closed without merging.
Merged
vilmibm
pushed a commit
that referenced
this pull request
Jun 29, 2021
Changed parsefileArg to return a string, reformatted testing, polishe…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unfortunately there is no
ALLstate for filtering pull requests; you have to specify all of the types (or specify nothing, but we have a default ofOPEN).This PR tweaks the PR filtering to match what graphql ultimately wants -- an array of pull request states.