Skip to content

Conversation

@mislav
Copy link
Contributor

@mislav mislav commented Nov 24, 2021

  • Supports passing a PR as argument, not just issues
  • Makes it non-fatal when project cards were not able to load due to permissions (unless projectCards were explicitly requested in export mode)
  • Cleans up legacy method for fetching issues
  • Displays the path component for GraphQL errors that have one: this will make it easier to debug which part of the query failed

Fixes #3346
Followup to #4794

@mislav mislav requested a review from a team as a code owner November 24, 2021 13:46
@mislav mislav requested review from vilmibm and removed request for a team November 24, 2021 13:46
Base automatically changed from issue-no-overfetch to trunk November 24, 2021 13:48
- Supports passing a PR as argument, not just issues
- Makes it non-fatal when project cards were not able to load
- Cleans up legacy method for fetching issues
@mislav mislav force-pushed the issue-view-resilient branch from 35fedea to 34fc5fb Compare November 24, 2021 17:49
Copy link
Contributor

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

}
`)

var issueCommentLast = shortenQuery(`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is smart!

@mislav mislav merged commit 323e53e into trunk Nov 29, 2021
@mislav mislav deleted the issue-view-resilient branch November 29, 2021 16:08
@VictorBatta VictorBatta mentioned this pull request Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Actions: cannot access issue that was added to an org project

2 participants