Improve queries in issue commands: no overfetching, support PR arguments
#4794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `issue comment` no longer fetches all issue fields and thus avoids the problem when loading failed due to token not having access to projects - `issue comment` now accepts either issue or pull number as argument.
- `issue close` no longer fetches all issue fields and thus avoids the problem when loading failed due to token not having access to projects - `issue close` now accepts either issue or pull number as argument.
- `issue reopen` no longer fetches all issue fields and thus avoids the problem when loading failed due to token not having access to projects - `issue reopen` now accepts either issue or pull number as argument.
vilmibm
approved these changes
Nov 23, 2021
samcoe
approved these changes
Nov 23, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove overfetching from the following commands, i.e. fetch only the GraphQL fields that are necessary for the operation (usually only
idandnumber):issue commentissue closeissue reopenissue deleteissue transferissue edit(non-interactive)Have the following commands work with PR arguments as well as issues, since PRs are a kind of issues:
issue commentissue closeissue reopenissue editFixes #4785, fixes #4202, fixes #4127
Partially addresses #3346
Followup to #3547
Commands to address in follow-up changes:
issue view- great if this worked with PRs and also survived the error when project cards could not be fetched due to permissions