Skip to content

Fix: Nil pointer dereference while previewing PR and Issues with empty body#405

Merged
vilmibm merged 2 commits intocli:masterfrom
arkentos:master
Feb 13, 2020
Merged

Fix: Nil pointer dereference while previewing PR and Issues with empty body#405
vilmibm merged 2 commits intocli:masterfrom
arkentos:master

Conversation

@arkentos
Copy link
Copy Markdown
Contributor

@arkentos arkentos commented Feb 13, 2020

Summary

closes #403

Details

The commit added an empty body check for both issues and PR for preview.
The code ignores the body and the formatting around it if body is empty

PR output

> ./bin/gh pr view -p 2 -R arkentos/tableturner
This is a test PR with empty body
arkentos wants to merge 1 commit into master from README
View this pull request on GitHub: https://github.com/arkentos/tableturner/pull/2

Issue output

./bin/gh issue view -p 1 -R arkentos/tableturner
This is a test issue with empty body
opened by arkentos. 0 comments.
View this issue on GitHub: https://github.com/arkentos/tableturner/issues/1

@arkentos arkentos requested review from mislav and vilmibm and removed request for mislav February 13, 2020 10:16
@billygriffin
Copy link
Copy Markdown
Contributor

billygriffin commented Feb 13, 2020

Thanks @arkentos. I can't comment on the code itself but just wanted any reviewers to be sure to reference #402 as well as I think there's potentially some overlap.

@billygriffin billygriffin mentioned this pull request Feb 13, 2020
Closed
vilmibm
vilmibm approved these changes Feb 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@vilmibm vilmibm merged commit 15d6d4b into cli:master Feb 13, 2020
@arkentos
Copy link
Copy Markdown
Contributor Author

arkentos commented Feb 14, 2020

thank you

@tinoji tinoji mentioned this pull request Feb 14, 2020
Closed
Stonre pushed a commit to Stonre/strands-fork that referenced this pull request Jul 21, 2025
@pgrayy
structured output - multi-modal input (cli#405)
1b83c5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vilmibm vilmibm vilmibm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nil pointer dereference while previewing PR and Issues with empty body

3 participants

@arkentos @billygriffin @vilmibm