Fix bug where branchProtectionRule doesn't exist in enterprise 2.22 #3922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 30, 2021
Contributor
|
Cool! Thanks for the quick look. FWIW I just built the https://github.com/cli/cli/tree/fix-branch-protection branch locally and it works again, so feeling positive :) |
vilmibm
approved these changes
Jun 30, 2021
|
Thank you for looking into this and solving the issue! |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Closed
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes adding the
branchProtectionRulefragment to the PR graphQL queries conditional on the PR having theHasBranchProtectionRulefeature. This used to be the behavior but was changed in #3804, so this PR just changes it back.Fixes #3919