Skip to content

Make sure editor is set properly & not overridden later#387

Merged
vilmibm merged 1 commit intocli:masterfrom
ahmedelgabri:master
Feb 13, 2020
Merged

Make sure editor is set properly & not overridden later#387
vilmibm merged 1 commit intocli:masterfrom
ahmedelgabri:master

Conversation

@ahmedelgabri
Copy link
Copy Markdown
Contributor

@ahmedelgabri ahmedelgabri commented Feb 12, 2020

Quoting @d0liver here

Looking at this because I had an issue that ended up being unrelated, but I wonder if else ifs aren't what was intended with the editor check here? Otherwise you'll end up overwriting the value with later checks in cases where multiple env variables are set.

ahmedelgabri referenced this pull request Feb 12, 2020
@ahmedelgabri
Check $GIT_EDITOR first
ff2d5fa
vilmibm
vilmibm approved these changes Feb 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

face palming. thanks!

@vilmibm vilmibm merged commit 65a7d05 into cli:master Feb 13, 2020
Stonre pushed a commit to Stonre/strands-fork that referenced this pull request Jul 21, 2025
@zastrowm
Now callers can subscribe and modify responses before they're sent to…
c412292 
… the model for processing. (cli#387)

We also don't support structured output as the parameters are not applicable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vilmibm vilmibm vilmibm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahmedelgabri @vilmibm