Fix showing Checks information in pr status#3804
Merged
Conversation
This was a regression in how `statusCheckRollup` is queried and stored. As a result, `gh pr status` did not include rendered information about checks related to each pull request. This switches the query builder to `PullRequestGraphQL()` to eliminate the outdated query.
samcoe
approved these changes
Jun 8, 2021
samcoe
reviewed
Jun 8, 2021
samcoe
approved these changes
Jun 10, 2021
This was referenced Jun 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An outdated GraphQL query was used in
pr statusto fetch Checks. It was technically valid, so it didn't error out on the server, but its results around Checks were not stored in a way that caused them to also be rendered.This switches to
PullRequestGraphQL()to build GraphQL queries, which is also used across the codebase, instead of manually rolling potentially error-prone queries by hand.Fixes #3794
Followup to #3547