Fix pr merge with GHE < 3.0
#3688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids loading authorship information for git commits, since it relies on a GraphQL API that wasn't available before GHE v3.0. The authorship information wasn't necessary for the merge operation anyway; just loading the last commit OID was.
vilmibm
approved these changes
May 21, 2021
samcoe
approved these changes
May 21, 2021
2 tasks
|
Good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids loading authorship information for git commits, since it relies on a GraphQL API (the
Commit.authorsconnection) that wasn't available before GHE v3.0. The full authorship information for commits wasn't necessary for the merge operation anyway; just loading the last commit OID was.Fixes #3687
Followup from #3547