Skip to content

Cross repo pr create#362

Merged
vilmibm merged 1 commit intomasterfrom
cross-repo-create
Feb 13, 2020
Merged

Cross repo pr create#362
vilmibm merged 1 commit intomasterfrom
cross-repo-create

Conversation

@vilmibm
Copy link
Copy Markdown
Contributor

@vilmibm vilmibm commented Feb 12, 2020

Closes #354

Currently we improperly specify the head ref when submitting a PR cross-repo. This PR fixes that.

Preview in browser and -w were and continue to be fine.

Most of the diff is testing.

@vilmibm vilmibm marked this pull request as ready for review February 12, 2020 22:11
@vilmibm vilmibm requested a review from outofambit February 12, 2020 22:11
@billygriffin billygriffin changed the title Cross repo create Cross repo pr create Feb 13, 2020
Copy link
Copy Markdown
Contributor

@outofambit outofambit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@vilmibm vilmibm merged commit 2e7fedd into master Feb 13, 2020
@mislav mislav deleted the cross-repo-create branch February 17, 2020 15:15
Stonre pushed a commit to Stonre/strands-fork that referenced this pull request Jul 21, 2025
Addresses cli#362

Small fix that needed to be plumbed through

Co-authored-by: Mackenzie Zastrow <zastrowm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

non-web PR creation fails for forks

2 participants