Skip to content

Enable showing ALL pr checks #3331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mislav wants to merge 3 commits into from
Closed

Enable showing ALL pr checks #3331

mislav wants to merge 3 commits into from

Conversation

@mislav
Copy link
Contributor

@mislav mislav commented Mar 30, 2021

In repositories with more than a 100 checks, this paginates and thus guarantees listing all checks associated with a PR.

Fixes #3040

@mislav
Copy link
Contributor Author

mislav commented Apr 23, 2021

Since this approach feels brittle, we decided to hold off doing this until we can rework our GraphQL adapter to better handle pagination.

@mislav mislav added the blocked label Apr 23, 2021
@mislav mislav mentioned this pull request May 18, 2021
Merged
4 tasks
@mislav mislav closed this in #3547 May 18, 2021
@mislav mislav deleted the pr-checks-100-plus branch July 20, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

2 more reviewers

@Small25 Small25 Small25 approved these changes

@codylee15 codylee15 codylee15 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

blocked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

gh pr checks does not show all checks if n > 100

4 participants

@mislav @Small25 @codylee15 @diminutivesloop