Skip to content

Manual site clean up#305

Merged
ampinsk merged 12 commits intogh-pagesfrom
site-fixes
Feb 7, 2020
Merged

Manual site clean up#305
ampinsk merged 12 commits intogh-pagesfrom
site-fixes

Conversation

@ampinsk
Copy link
Copy Markdown

@ampinsk ampinsk commented Feb 5, 2020 •
edited
Loading

This is a follow up to #236

So far, this PR includes:

  • Some naming clean up
  • Moved examples and installation pages inside of /manual and updated links
  • Added an index to /manual and updated links
  • Responsive manual side nav

To Dos:

  • Sidenav not taking up full height
  • Remove gh from sidenav
  • Right now, I'm showing both pr and issue examples on the command pages. It's a little confusing and should just be issue or pr examples on their respective pages.
  • Add content on forks with gh pr create
  • Address @sophshep's review: WIP - Add man pages #236 (review)

ampinsk
ampinsk commented Feb 5, 2020
View reviewed changes
manual/index.md
permalink: /:path/:basename
---

## GitHub CLI
Copy link
Copy Markdown
Author

@ampinsk ampinsk Feb 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billygriffin I added this index page called Overview that will load at /manual! Would love your thoughts and input on the content for this. I grabbed what's here right now from the repo README

@vilmibm vilmibm mentioned this pull request Feb 5, 2020
Closed
@vilmibm
Copy link
Copy Markdown
Contributor

vilmibm commented Feb 6, 2020

👋 sorry for the hassle but this work should probably be moved over to the new github/cli.github.com repo

@ampinsk ampinsk marked this pull request as ready for review February 7, 2020 23:23
@ampinsk
Copy link
Copy Markdown
Author

ampinsk commented Feb 7, 2020

Merging to port to the new repo!

@ampinsk ampinsk merged commit 718bac8 into gh-pages Feb 7, 2020
@ampinsk ampinsk linked an issue Feb 8, 2020 that may be closed by this pull request
Docs/man-page #77
Closed
3 tasks
@mislav mislav deleted the site-fixes branch February 17, 2020 15:16
Stonre pushed a commit to Stonre/strands-fork that referenced this pull request Jul 21, 2025
@zastrowm
fix: Migrate Mistral structured_output to an iterator (cli#305)
13d7b81 
Mistral was merged after the latest iterator changes (cli#291) so it didn't have the latest and greatest

---------

Co-authored-by: Mackenzie Zastrow <zastrowm@users.noreply.github.com>
@mamirhassan54-create

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docs/man-page

3 participants

@ampinsk @vilmibm @mamirhassan54-create