Merged
Conversation
- They don't accurately reflect the visitor's current signed-in status on github.com - They don't redirect back to GitHub CLI site when used - Signing in to GitHub doesn't benefit the visitor of the GitHub CLI site at all, since the page won't be different in any way.
This makes it easer for the user to copy to clipboard without having to precisely adjust their selection.
I couldn't figure out what's broken with typed.js library, so I've reimplemented the typing animation from scratch in a simpler way. Now the typing contents is read from HTML (instead of being hardcoded in JS) and should be easy to understand and to maintain.
ampinsk
reviewed
Jan 30, 2020
ampinsk
left a comment
ampinsk
left a comment
There was a problem hiding this comment.
I can't speak to all the details of the code here, but almost everything works as expected, and looks easy to understand what's going on!
The one thing I noticed is that triple clicking doesn't seem to copy for me. 🤔
vilmibm
approved these changes
Jan 31, 2020
Contributor
Author
To clarify: the thing I added is not that triple-click auto-copies, but that triple clicking will select only the installation instructions text and not the rest of the text around the |
Stonre
pushed a commit
to Stonre/strands-fork
that referenced
this pull request
Jul 21, 2025
* feat: add Mistral model support to strands * fix: testcase and better error handling * fix: Minor doc update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes typing animation
Dynamically generate repo & download URLs instead of hardcoding them
Remove “Sign in, Sign up” links from navigation bar
Make it easier for user to
copyselectbrew installinstructions by triple-clicking them on macOS