Merged
Conversation
Contributor
Author
|
It seems there are some tests still using the legacy implementation for HTTP stubbing, any interest in a PR updating them? |
Contributor
|
@cristiand391 that would be much appreciated. Thanks for looking into it! |
Contributor
It would be great if you ported that, but please do submit a separate PR so that the changeset is separate from simply removing dead code. Regarding this PR: I've spent some time trying to see if we can set up a linter that detects unused exported functions/types, but there isn't a bug-free solution out there that I could find. golangci/golangci-lint#791 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes some unused methods from
httpmock.