Conversation
mislav
previously requested changes
Jan 22, 2020
Contributor
mislav
left a comment
mislav
left a comment
There was a problem hiding this comment.
Hi, thank you for working on this!
One important bit to clear out of the way: while previewing this branch, I've noticed that it took unusually long to fetch it. It seems that this is because all of vendor/gems/ and node_modules/ got checked into version control, totaling to ~ 210 MB on disk. Since these are only necessary for development, I suggest that you add these paths to .gitignore and to recreate (i.e. force-push) a lighter version of this branch so that this doesn't become a permanent part of our repository's history. Thank you!
…flares. Added commend pills behind the cli window.
…pilled commands behind the cli window
mislav
force-pushed
the
add-landing-page-v2
branch
from
4fdb08e to
7a17a54
Compare
- They don't accurately reflect the visitor's current signed-in status on github.com - They don't redirect back to GitHub CLI site when used - Signing in to GitHub doesn't benefit the visitor of the GitHub CLI site at all, since the page won't be different in any way.
This makes it easer for the user to copy to clipboard without having to precisely adjust their selection.
I couldn't figure out what's broken with typed.js library, so I've reimplemented the typing animation from scratch in a simpler way. Now the typing contents is read from HTML (instead of being hardcoded in JS) and should be easy to understand and to maintain.
Landing page fixes
…s to show proper outputs
cchristous
pushed a commit
to cchristous/cli
that referenced
this pull request
Feb 28, 2026
* feat: page size and pagination for get notifications cmd * fix(notifications): get all by default * fix: use url.Values to build query params
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@trosage thank you for wrapping this up!
Handy links
Some people who are working on this project that you should know in case you have questions
@ampinskis the product designer working on CLI, reach out to her with any questions on the terminal output/how it should look if you have any@leereillyis the PM@nerdnehais the eng managerHere are the remaining todos
Terminal animation: Fix glitch, add output for last 3 commands, and dots below the terminal. The JS is in
terminal.js. It relies on typed.js.TODOs inside ofterminal.jswhere the output needs to be updated . Ive completed the output for the first one (gh pr status) the last 3 need to be updated. Here is a gist with the output for each command.Add dropdown for Linux download option. Its completed for Mac and Windows. There are 2
TODOs within theindex.htmlfile.Add dot pattern behind terminal
Add confetti near terminalAdd pill shaped commands below the terminal
Add google analytics click tracking for the main CTAs
Check all links to make sure they point to the right place. Since we dont have that content for the Manual and Documentation in this PR yet Ive left them blank - im unsure what the final path will be. @ampinsk is working on updating the design for the Manual pages, verify with her for the url. She is working off of
docs-testbranch hereI believe thats it! Thank you Tyson!
cc'ing others for status update! @teenage-witch @AmandaSwan (couldnt tag @mariahenrikson in this repo)