Fix issue label overrides caused by pagination#2190
Merged
Conversation
…ation iterations This is to avoid subtle deserialization issues in nested slices.
mislav
force-pushed
the
issues-data-race
branch
from
fea9725 to
813fbc9
Compare
mislav
approved these changes
Oct 14, 2020
Contributor
mislav
left a comment
mislav
left a comment
There was a problem hiding this comment.
Thank you!! 🌟
I've pushed commits that simplify your original changeset (so that the diff is minimal), make the test more readable, and address the same issue in other pagination instances where we reused the same struct.
Contributor
Author
|
@mislav It looks great to me. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1443
Thankfully, my commits were partially reviewed by @mislav in quiye#2