Improve naming of Windows release asset#207
Merged
Conversation
- Allow .msi file to be specified via input to action - Delete obsolete .exe file after uploading .msi
mislav
commented
Jan 9, 2020
| const assetFile = fs.readFileSync(MSI_PATH); | ||
|
|
||
| await uploadAsset(GITHUB_TOKEN, release, assetFile); | ||
| const assetFile = fs.createReadStream(MSI_PATH); |
Contributor
Author
There was a problem hiding this comment.
This switches to a read stream for the file upload to avoid loading the whole binary file contents to memory
mislav
commented
Jan 9, 2020
| const octokit = new github.GitHub(token); | ||
| /** | ||
| * @param {github.GitHub} octokit | ||
| * @param {Octokit.ReposGetReleaseByTagResponse} release |
Contributor
Author
There was a problem hiding this comment.
These @param statements are JSDoc syntax which help VS Code (and TypeScript compiler when used for .js files) follow argument types across function calls. This is only useful for editor features such as autocompletion
vilmibm
approved these changes
Jan 9, 2020
mislav
added a commit
that referenced
this pull request
Jan 23, 2020
Improve naming of Windows release asset
Stonre
pushed a commit
to Stonre/strands-fork
that referenced
this pull request
Jul 21, 2025
cchristous
pushed a commit
to cchristous/cli
that referenced
this pull request
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems:
gh_{version}_windows_amd64.exethat was used to generate the MSI installer remains among release assets after the MSI has been uploaded.This PR:
gh_{version}_windows_amd64.msi;.exeafter uploading the.msi;npm run buildtask to JS actions to facilitate rebuilding ofdist/index.jsafter changes.Followup to #148, #201