Don't send a request when the contents haven't changed#1828
Conversation
By doing this, the command will finish faster if the user canceled the editing.
mislav
reviewed
Sep 21, 2020
Contributor
mislav
left a comment
mislav
left a comment
There was a problem hiding this comment.
Nice catch! The fix looks good, but I'm not sure if the added tests asserts that no API update has happened? It feels to me like the added tests might have had passed without the fix as well.
Contributor
|
@mislav the test will fail if a POST is made which I think is good enough, here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By doing this, the command will finish faster if the user canceled the editing.