`--attach` stack: review feedback round - #14200

Merged

BagToad merged 40 commits into

bagtoad/attach-issue-commandsfrom

bagtoad/attach-review-feedback

Aug 25, 2026

Commits on Aug 19, 2026

Consolidate token type constants

BagToad
and
Copilot
committed
e3d0326
Move token inspection TODOs to call sites

BagToad
and
Copilot
committed
804304a
Detach shared comment from struct field

BagToad
and
Copilot
committed
697605b
Remove redundant decoding tests

BagToad
and
Copilot
committed
06b86ae
Remove test reference from comment

BagToad
and
Copilot
committed
bfffa55
Correct package documentation name

BagToad
and
Copilot
committed
89ca08a
Correct stale video test comment

BagToad
and
Copilot
committed
51b3aa2
Refactor validation types and update size limit message

BagToad
and
Copilot
committed
7f5be71

Commits on Aug 24, 2026

Validate image attachment markdown

BagToad
and
Copilot
committed
f0b5f18
Remove duplicate test cases

BagToad
and
Copilot
committed
d038799
Document unrewritable reference limitation

BagToad
and
Copilot
committed
27dd72f
Detect remote destinations by URL scheme

BagToad
and
Copilot
committed
cf3bc43
Preserve whitespace in bracketed destinations

BagToad
and
Copilot
committed
6d27fc9
Remove empty test placeholder

BagToad
and
Copilot
committed
a04dcf4
Make test intent explicit

BagToad
and
Copilot
committed
47b232e
Rename golden file regeneration flag

BagToad
and
Copilot
committed
df67f15
Delete confusing test group headings

BagToad
and
Copilot
committed
a075e86
Test mixed video reference orderings

BagToad
and
Copilot
committed
56f07af
Fold redundant scenario into table

BagToad
and
Copilot
committed
43f3568
Assert upload host token normalization

BagToad
and
Copilot
committed
6b970a2
Point upload TODO at DoRequest

BagToad
and
Copilot
committed
319a0bd
Clarify attachment permission errors

BagToad
and
Copilot
committed
91cdea2
Clarify upload request tests

BagToad
and
Copilot
committed
81e3b32
Clarify upload error messages

BagToad
and
Copilot
committed
4687c5d
Stub upload file opening

BagToad
and
Copilot
committed
1eaba3c

Commits on Aug 25, 2026

Cover multi-hash attachment arguments

BagToad
and
Copilot
committed
6dda338
Document partial upload behavior

BagToad
and
Copilot
committed
ea0e187
Clarify attachment alt text help

BagToad
and
Copilot
committed
52d5a3f
Correct attachment conflict caller

BagToad
and
Copilot
committed
6c46619
Rename attachment argument slice

BagToad
and
Copilot
committed
fb6d377
Preserve markdown for empty additions

BagToad
and
Copilot
committed
bb63c24
Clarify comment attachment help

BagToad
and
Copilot
committed
886af95
Separate comment test case braces

BagToad
and
Copilot
committed
6abc068
Document permission-aware repository stub

BagToad
and
Copilot
committed
49e92c2
Document partial PR attachment outcomes

BagToad
and
Copilot
committed
ae5d443
Remove redundant prompt failure stubs

BagToad
and
Copilot
committed
912e411
Document partial issue attachment outcomes

BagToad
and
Copilot
committed
c81d081
Validate issue type before uploads

BagToad
and
Copilot
committed
eb9839e
Test editor attachment rewriting

BagToad
and
Copilot
committed
ac2222a
Remove redundant issue prompt stub

BagToad
and
Copilot
committed
cd94f8c