Update glamour to v2 - #14148
Draft
heaths wants to merge 2 commits into
Draft
Conversation
github-actions
Bot
added
external
Contributor
Author
|
Draft until cli/go-gh#281 is merged, a new version of go-gh is released, and the |
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades Markdown rendering to Glamour v2 to prevent wrapped links from producing broken URLs.
Changes:
- Migrates Glamour and Lip Gloss imports to v2.
- Updates rendering snapshots for changed wrapping behavior.
- Temporarily replaces
go-ghwith its pending v2-compatible fork.
Show a summary per file
| File | Description |
|---|---|
go.mod |
Updates rendering dependencies and temporary go-gh replacement. |
go.sum |
Updates dependency checksums. |
pkg/markdown/markdown.go |
Uses Glamour v2 types. |
pkg/cmd/extension/browse/browse.go |
Migrates README rendering to Glamour v2. |
pkg/cmd/status/status.go |
Migrates status layout to Lip Gloss v2. |
pkg/cmd/status/status_test.go |
Updates status layout expectations. |
pkg/cmd/agent-task/shared/testdata/log-1-want.txt |
Updates transcript wrapping fixture. |
pkg/cmd/agent-task/shared/testdata/log-2-want.txt |
Updates transcript wrapping fixture. |
Review details
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 7/8 changed files
- Comments generated: 1
- Review effort level: Balanced
Effectively restores status_test.go since Lip Gloss v2 changed how it calculates width to include the column separator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3718.
This updates the markdown stack to Glamour v2 and keeps the status column spacing aligned with trunk under Lip Gloss v2. Lip Gloss v2 counts the right border inside
Width(), so the left status column adds one cell to preserve the previous content width and spacing.The log fixture changes are separate from that width adjustment. Glamour v2 now wraps with Lip Gloss rather than the previous
ansi-based wrapper, so break behavior changed for width-constrained text. For example,-opreviously could wrap with the-at the end of the line, but now it stays together and wraps one cell later.