Skip to content

Stop bumping homebrew on release - #13479

Merged
williammartin merged 3 commits into
trunkfrom
wm-no-homebrew
May 21, 2026
Merged

Stop bumping homebrew on release#13479
williammartin merged 3 commits into
trunkfrom
wm-no-homebrew

Conversation

@williammartin

@williammartin williammartin commented May 21, 2026

Copy link
Copy Markdown
Member

Description

Removes the automated Homebrew formula bump step from the release process.

Because the bump required a legacy PAT to open a PR between repos, it was deemed too much security risk. We now rely on Homebrew autobump, which runs every ~3 hours.

This should be paired with a homebrew-core PR for:

diff --git a/Formula/g/gh.rb b/Formula/g/gh.rb
index a1a1a276492..0d6216cc4aa 100644
--- a/Formula/g/gh.rb
+++ b/Formula/g/gh.rb
@@ -12,8 +12,6 @@ class Gh < Formula
     strategy :github_latest
   end
 
-  no_autobump! because: :bumped_by_upstream
-
   bottle do
     sha256 cellar: :any_skip_relocation, arm64_tahoe:   "4eb5c69f4666a1cac19d67ecf870389c76257130db90075c870587f1afcec75a"
     sha256 cellar: :any_skip_relocation, arm64_sequoia: "3192c6e260a00cae347ce9d1e16f3a5680f9adfbf03f6046e92ebd08add93e44"

@@ -1,26 +0,0 @@
name: homebrew-bump-debug

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This existed from a period of time when I was trying to debug homebrew failures. Was never used since.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the automated Homebrew formula bump from the release workflow and updates release documentation to reflect relying on Homebrew’s autobump instead of opening PRs via a legacy PAT.

Changes:

  • Removed the Homebrew bump step from the main deployment workflow (and deleted the standalone debug workflow).
  • Updated release docs to stop claiming the release process bumps Homebrew automatically and to describe Homebrew autobump.
  • Adjusted the deep-dive documentation to remove the workflow-step details for the Homebrew bump.
Show a summary per file
File Description
docs/releasing.md Removes “Homebrew bump” from the automated release checklist and adds a “Bumping Homebrew” section describing autobump.
docs/release-process-deep-dive.md Removes Homebrew bump from the high-level workflow overview and deletes the workflow-step snippet; updates narrative around Homebrew handling.
.github/workflows/homebrew-bump.yml Deletes the standalone debug workflow that could open Homebrew bump PRs.
.github/workflows/deployment.yml Removes the Homebrew bump PR step from the production release workflow.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 4/4 changed files
  • Comments generated: 2

Comment thread docs/release-process-deep-dive.md Outdated
Comment thread docs/releasing.md
williammartin and others added 2 commits May 21, 2026 17:15
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@williammartin
williammartin marked this pull request as ready for review May 21, 2026 15:16
@williammartin
williammartin requested a review from a team as a code owner May 21, 2026 15:16
@williammartin
williammartin merged commit 0a68614 into trunk May 21, 2026
16 checks passed
@williammartin
williammartin deleted the wm-no-homebrew branch May 21, 2026 17:39
mdrichardson added a commit to mdrichardson/max-flow that referenced this pull request May 21, 2026
- Count probe now ships a canonical -F-variables gh api graphql command;
  past incident: agent wrote \" inside PowerShell single quotes, GraphQL
  silently rejected the payload inside a catch {}, monitor assumed 0
  comments for a full session. Probe failure no longer silently means
  "0 comments" — falls through to full REST fetch and surfaces in the
  polling summary.
- Phase 7 thread-resolve was broken end-to-end: the single-comment REST
  path 404s (right path is pulls/comments/{id}, no PR number), and
  PullRequestReviewComment has no pullRequestReviewThread field in the
  current GitHub GraphQL schema. Replaced with reviewThreads + client-
  side databaseId filter; verified against cli/cli#13479 in bash and
  PowerShell.
- Poll loop now explicitly forbids improvised "CI fixed, stop here?" /
  "waiting on reviewer, exit?" prompts. Tick-step-8 stop conditions
  and SIGINT are the only authorized exits.

Co-Authored-By: Claude <noreply@anthropic.com>
derekrivers added a commit to derekrivers/atlas that referenced this pull request Jun 27, 2026
…NTATION_UPDATE mapper (ATLAS-66) (#114)

Add documentation as a third evidence source, paralleling reviews (ATLAS-65):

atlas.github (transport + docs normaliser):
- fetch_pr_files(owner, repo, pr_number) on the GitHubClient Protocol and
  GitHubRESTClient, calling _get(.../pulls/{n}/files, result_key=None) — same
  bare-array path as fetch_pr_reviews, inheriting per_page/304/Link behaviour.
- NormalisedDocs (frozen webhook-swap shape) + normalise_pr_files(files, *,
  head_sha): filters to docs/ paths; None when none touched (absence is the
  signal); else one PASSED record with sorted docs_paths and the synthesised
  pin (docs:<head_sha>, head_sha, payload_hash of the docs subset only).

atlas.evidence (docs mapper + ingest):
- map_docs_to_evidence: system-tier DOCUMENTATION_UPDATE, status verbatim,
  pin triple from the docs record (satisfies the ATLAS-61 guard).
- ingest_docs(docs | None): persists the one record, or [] when None.

Tests + a recorded cli/cli#13479 pr_files fixture (4 files, 2 under docs/).
Two seeded defects each fail a named test: docs/ -> doc/ and the inverted
empty check (the absence-based guarantee criterion 2 protects).

Co-authored-by: derekrivers <dyk3rz@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants