Add acceptance tests for discussion list#13151
Closed
maxbeizer wants to merge 2 commits into
Closed
Conversation
github-actions
Bot
added
unmet-requirements
external
|
Thanks for your pull request! Unfortunately, it doesn't meet the minimum requirements for review:
Please update your PR to address the above. Requirements:
This PR will be automatically closed in 7 days if these requirements are not met. |
maxbeizer
force-pushed
the
discussion-acceptance-tests
branch
from
1e6752d to
1088758
Compare
Contributor
Author
Read-only smoke tests against cli/cli that verify: - TTY and non-TTY table output - JSON envelope (totalCount, discussions, next cursor) - Closed state filtering - Category filtering - Sort and order flags These are lightweight read-only tests that catch GQL schema mismatches without requiring test org infrastructure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
maxbeizer
force-pushed
the
discussion-acceptance-tests
branch
from
1088758 to
5056405
Compare
- Fix non-TTY smoke test pattern: non-TTY output uses bare numbers without '#' prefix, so use '\d+\tOPEN' instead of '#\d+' - Add computed 'state' field to discussionListFields so --json state works in acceptance tests (ExportData already supports it) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Thanks for your pull request! Unfortunately, it doesn't meet the requirements for review:
Please update your PR to address the above. This PR will be automatically closed in 7 days if these requirements are not met. Full contribution requirements
|
Member
|
Reopened as it was closed by automation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds read-only acceptance tests for
gh discussion list, targetingcli/clias a known public repo with discussions enabled.Tests
Verifies:
#<number>formatSTATEcolumntotalCount,discussions,nextcursor)--state closed)--category general)--sort created --order asc)Approach
These are read-only smoke tests — no repo creation or cleanup needed. They catch GQL schema mismatches (like the
statevsclosedbug we hit) without requiring test org infrastructure.When
discussion createlands, we can add full CRUD tests usingGH_ACCEPTANCE_ORG.Stacked on #13084.