Skip to content

Fix search prs --web URL type parameter#12618

Open
gechr wants to merge 1 commit intocli:trunkfrom
gechr:gc/fix-search-prs-web-url-type
Open

Fix search prs --web URL type parameter#12618
gechr wants to merge 1 commit intocli:trunkfrom
gechr:gc/fix-search-prs-web-url-type

Conversation

@gechr
Copy link

@gechr gechr commented Feb 5, 2026 •
edited
Loading

Fixes #10733

Appreciate the help wanted label is not on the original issue, so feel free to close this, but it was a quick fix and was annoying me, so I submitted a drive-by PR.

@gechr gechr requested a review from a team as a code owner February 5, 2026 00:26
@gechr gechr requested review from babakks and Copilot February 5, 2026 00:26
@gechr gechr temporarily deployed to cli-automation February 5, 2026 00:27 — with GitHub Actions Inactive
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Feb 5, 2026
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Thank you for your pull request! 🎉

This PR appears to fix the following issues that are not labeled with help wanted Contributions welcome :

As outlined in our Contributing Guidelines, we expect that PRs are only created for issues that have been labeled help wanted.

While we appreciate your initiative, please note that:

  • PRs for non-help wanted issues may not be reviewed immediately as they might not align with our current priorities
  • The issue might already be assigned to a team member or planned for a specific release
  • We may need to close this PR. For example, if it conflicts with ongoing work or architectural decisions

What happens next:

  • Our team will review this PR and the associated issues
  • We may add the help wanted label to the issues, if appropriate, and review this pull request
  • In some cases, we may need to close the PR. For example, if it doesn't fit our current roadmap

Thank you for your understanding and contribution to the project! 🙏

This comment was automatically generated by cliAutomation.

@gechr gechr force-pushed the gc/fix-search-prs-web-url-type branch from 22360f5 to 38e1f0b Compare February 5, 2026 00:28
Copilot AI reviewed Feb 5, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where gh search prs --web was opening the browser on the Issues tab instead of the Pull Requests tab. The issue was that the URL type parameter was being set incorrectly for pull request searches.

Changes:

  • Added URL type constants for pull requests and issues in query.go
  • Modified URL() method to map query.Qualifiers.Type values to correct GitHub URL type parameters
  • Refactored regexp variable declarations to use grouped var declaration

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
pkg/search/query.go Added URLTypePullRequests and URLTypeIssues constants for GitHub search URL type parameters
pkg/search/searcher.go Fixed URL() to map pr/issue qualifiers to correct URL types; grouped regexp declarations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gechr gechr force-pushed the gc/fix-search-prs-web-url-type branch 3 times, most recently from 93bd240 to 8b1d5e4 Compare February 5, 2026 00:47
@gechr gechr force-pushed the gc/fix-search-prs-web-url-type branch from 8b1d5e4 to 5283004 Compare February 5, 2026 00:48
@gechr gechr requested a review from Copilot February 5, 2026 00:49
Copilot AI reviewed Feb 5, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@babakks babakks Awaiting requested review from babakks babakks is a code owner automatically assigned from cli/code-reviewers

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Using --web on search prs open the Issues tab on the browser

2 participants

@gechr @cliAutomation