`gh pr edit`: Add support for Copilot as reviewer with search capability, performance and accessibility improvements by BagToad · Pull Request #12567 · cli/cli

BagToad · 2026-01-28T06:08:10Z

Description

Adds Copilot Code Review (CCR) support and multiselect-with-search for reviewers in gh pr edit.

Key changes

API layer (api/queries_pr.go):

New RequestReviewsByLogin GraphQL mutation with userLogins, botLogins, teamSlugs (github.com only)
New SuggestedReviewerActors query combining suggestedReviewerActors, collaborators, and org teams
ReviewerCandidate interface with ReviewerUser, ReviewerBot, ReviewerTeam types
DisplayName()/DisplayNames() methods for user-friendly display (e.g., "Copilot (AI)")
Team slug extraction (org/slug → slug) moved into REST functions

Query builder (api/query_builder.go):

Added ...on Bot{login} to prReviewRequests for Copilot support (silently ignored on GHES)

Edit command (pkg/cmd/pr/edit/edit.go):

reviewerSearchFunc for multiselect-with-search
Split updates: updatePullRequestReviewsGraphQL (github.com) vs updatePullRequestReviewsREST (GHES)
partitionReviewersByType to separate users, bots, teams
@copilot flag support for --add-reviewer/--remove-reviewer

Shared (pkg/cmd/pr/shared/):

EditableReviewers struct with separate Default (display) and DefaultLogins (API)
NewCopilotReviewerReplacer for @copilot → copilot-pull-request-reviewer

Notes for reviewers

GHES compatibility: Bot fragment silently ignored; falls back to REST for mutations
requestReviewsByLogin uses union: false (replace mode) to set the entire reviewer set
Copilot bot logins get [bot] suffix in API layer before mutation

Enables Copilot to be requested as a pull request reviewer, supporting both interactive and non-interactive flows. Introduces new reviewer search functionality, updates reviewer partitioning to distinguish users, bots, and teams, and adds a GraphQL mutation for reviewer management on github.com. Updates help text, tests, and internal APIs to support Copilot reviewer login and display names, while maintaining compatibility with GitHub Enterprise Server.

Copilot

Pull request overview

Adds Copilot Code Review (CCR) support and a multi-select-with-search experience for editing PR reviewers via gh pr edit, including new API queries/mutations to support bots and improved reviewer display names.

Changes:

Introduces reviewer search plumbing in the edit flow and adds a github.com-specific GraphQL mutation path for setting reviewers (including Copilot bot).
Extends PR review-request GraphQL selection to include Bot and adds display-name helpers for reviewers (e.g., “Copilot (AI)”).
Adds @copilot reviewer replacement support and related unit tests.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
pkg/cmd/pr/shared/params_test.go	Adds tests for `@copilot` reviewer replacement behavior.
pkg/cmd/pr/shared/params.go	Splits Copilot replacement into assignee vs reviewer logins.
pkg/cmd/pr/shared/editable.go	Introduces `EditableReviewers`, wires reviewer search prompting, and optimizes metadata fetching decisions.
pkg/cmd/pr/edit/edit_test.go	Updates edit command tests for new reviewer flow/mutation behavior and GHES compatibility.
pkg/cmd/pr/edit/edit.go	Wires reviewer search, partitions reviewers by type, and adds github.com GraphQL vs GHES REST reviewer update paths.
api/query_builder.go	Adds `...on Bot{login}` to PR review request selection for Copilot support.
api/queries_repo.go	Introduces separate constants for Copilot assignee vs reviewer bot logins.
api/queries_pr.go	Adds display helpers, REST team slug extraction, new reviewer mutation, and reviewer suggestion query/types.

Comments suppressed due to low confidence (1)

pkg/cmd/pr/edit/edit.go:582

partitionReviewersByType classifies bots only when the value equals api.CopilotReviewerLogin. If the search flow (or existing review requests) yields any other bot login, it will be treated as a user and sent to the wrong mutation input. Either broaden bot detection (e.g., by encoding type in the selection key or maintaining a map of login→type from search results) or ensure only Copilot bots can be selected.

// partitionReviewersByType splits reviewer identifiers into users, bots, and teams.
// Team identifiers are in the form "org/slug" and are returned as-is.
// Bot logins (currently only Copilot) are identified and returned separately.
func partitionReviewersByType(values []string) (users []string, bots []string, teams []string) {
	for _, v := range values {
		if v == "" {
			continue
		}
		if strings.ContainsRune(v, '/') {
			// Team: org/slug format, pass as-is
			teams = append(teams, v)
		} else if v == api.CopilotReviewerLogin {
			bots = append(bots, v)
		} else {
			users = append(users, v)
		}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

api/queries_pr.go

pkg/cmd/pr/shared/editable.go

pkg/cmd/pr/edit/edit.go

api/queries_pr.go

Always send explicit lists for userLogins, botLogins, and teamSlugs in RequestReviewsByLogin mutation, even when empty. Previously, empty slices were omitted due to omitempty JSON behavior and len > 0 checks, which prevented clearing all reviewers when using replace mode. Empty slices are harmless no-ops in union mode, so we now send them unconditionally for simpler logic. Add test to verify the mutation receives empty slices when all reviewers are removed.

Each source (suggestions, collaborators, teams) has base quota of 5. Unfilled slots cascade to later sources, allowing up to 15 total. Adds unit tests with HTTP mocks.

Fetch name field in reviewRequests GraphQL query and show as 'login (Name)'.

Query aliased fields without search filter to get stable counts.

Reword the comment for CopilotAssigneeLogin to indicate it refers to Copilot when retrieved as an assignee. This updates wording from the previous 'Actor/assignable actors' phrasing for clarity; no code behavior changed.

Remove a redundant struct-level comment and update the DefaultLogins field comment in pkg/cmd/pr/shared/editable.go to more accurately describe its purpose: used to disambiguate actors from display names rather than to compute add/remove sets.

Add clarifying comment in pkg/cmd/pr/edit/edit.go to note that missing assignee/reviewer search functions trigger a downstream fallback to legacy fetching. In pkg/cmd/pr/shared/editable.go remove a redundant line and add a TODO urging migration of non-interactive assignee updates to use the new logins input with ReplaceActorsForAssignable to avoid unnecessary fetching. These are comment and doc changes to clarify intent and future improvements.

Update comment in FetchOptions to specify that the APIs used for both GHES and GitHub.com accept user logins and team slugs directly, clarifying why non-interactive flows with Add/Remove don't need to fetch reviewers/teams. Comment-only change; no functional modifications.

babakks

LGTM!

api/queries_pr.go

Address PR review comments: code consistency and DRY improvements - Add botTypeName const for consistency with teamTypeName - Create extractTeamSlugs helper using strings.SplitN to simplify team slug extraction logic - Replace duplicate code in AddPullRequestReviews and RemovePullRequestReviews with extractTeamSlugs helper - Fix ClientMutationId naming with explicit graphql tag for consistency with other mutations in the codebase

BagToad temporarily deployed to cli-automation January 28, 2026 06:08 — with GitHub Actions Inactive

BagToad changed the title ~~gh pr editAdd CCR and reviewer MultiSelectWithSearch~~ gh pr edit: Add CCR and reviewer MultiSelectWithSearch Jan 28, 2026

BagToad changed the title ~~gh pr edit: Add CCR and reviewer MultiSelectWithSearch~~ gh pr edit: Add support for Copilot as reviewer with search capability, performance and accessibility improvements Jan 28, 2026

BagToad force-pushed the kw/multi-select-with-search-and-ccr branch from 617a88d to 738b82d Compare January 28, 2026 06:11

BagToad marked this pull request as ready for review January 28, 2026 16:27

BagToad requested a review from a team as a code owner January 28, 2026 16:27

BagToad requested review from babakks and Copilot January 28, 2026 16:27

BagToad temporarily deployed to cli-automation January 28, 2026 16:27 — with GitHub Actions Inactive

cliAutomation assigned BagToad Jan 28, 2026

Copilot started reviewing on behalf of BagToad January 28, 2026 16:27 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

BagToad added 7 commits January 28, 2026 10:50

Remove redundant comment

846d661

Fix return proper slug only for ReviewerTeam

7f8ca2c

Implement cascading quota for reviewer suggestions

2d191e5

Each source (suggestions, collaborators, teams) has base quota of 5. Unfilled slots cascade to later sources, allowing up to 15 total. Adds unit tests with HTTP mocks.

Merge branch 'trunk' into kw/multi-select-with-search-and-ccr

43f802f

Include name in reviewer display for existing review requests

484526d

Fetch name field in reviewRequests GraphQL query and show as 'login (Name)'.

Use unfiltered totalCount for reviewer 'more results' display

c8b1409

Query aliased fields without search filter to get stable counts.

BagToad mentioned this pull request Jan 30, 2026

gh pr create --reviewer ... is slow in repos with many possible reviewers #11501

Open

BagToad added 4 commits January 30, 2026 11:17

Clarify Copilot assignee comment

7303c44

Reword the comment for CopilotAssigneeLogin to indicate it refers to Copilot when retrieved as an assignee. This updates wording from the previous 'Actor/assignable actors' phrasing for clarity; no code behavior changed.

Clarify EditableReviewers comment

4569aae

Remove a redundant struct-level comment and update the DefaultLogins field comment in pkg/cmd/pr/shared/editable.go to more accurately describe its purpose: used to disambiguate actors from display names rather than to compute add/remove sets.

babakks approved these changes Feb 3, 2026

View reviewed changes

api/queries_pr.go Outdated Show resolved Hide resolved

api/queries_pr.go Outdated Show resolved Hide resolved

api/queries_pr.go Outdated Show resolved Hide resolved

api/queries_pr.go Show resolved Hide resolved

api/queries_pr.go Outdated Show resolved Hide resolved

BagToad force-pushed the kw/multi-select-with-search-and-ccr branch from d7e41c1 to ebf932a Compare February 4, 2026 22:15

Add toGitHubV4Strings helper to reduce code duplication

c0febc1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`gh pr edit`: Add support for Copilot as reviewer with search capability, performance and accessibility improvements#12567

`gh pr edit`: Add support for Copilot as reviewer with search capability, performance and accessibility improvements#12567
BagToad wants to merge 14 commits intotrunkfrom
kw/multi-select-with-search-and-ccr

BagToad commented Jan 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

babakks left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

BagToad commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Key changes

Notes for reviewers

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

babakks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

BagToad commented Jan 28, 2026 •

edited

Loading